bug: Don't block for PodIP population#4535
Open
markmandel wants to merge 1 commit intoagones-dev:mainfrom
Open
bug: Don't block for PodIP population#4535markmandel wants to merge 1 commit intoagones-dev:mainfrom
markmandel wants to merge 1 commit intoagones-dev:mainfrom
Conversation
This _finally_ fixes a bug we introduced in agones-dev#3764 where a GameServer blocks its state at Starting until the PodIP is populated - which slowed down scaling and a bunch of other things for something that not everyone needed. This is no longer the case -- PodIP will be populated on the GameServer as it becomes populated on the Pod and is no longer blocking. ** If you are used to the original behaviour, make sure to factor this into your existing architecture when upgrading.** Details: - Add syncGameServerPodIPs to update addresses for Scheduled/Ready/Reserved/Allocated GameServers - Enqueue GameServer on PodIP changes in pod update handler - Remove blocking PodIPs check in syncGameServerStartingState; apply IPs non-blocking instead - Apply PodIPs non-blocking in syncGameServerRequestReadyState - Refactor unit tests to be table-based, since there was so much repetition Closes agones-dev#3960 Signed-off-by: Mark Mandel <mark@compoundtheory.com>
|
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
Collaborator
|
Build Succeeded 🥳 Build Id: 75656263-e0f7-4c5e-a318-efc3336b4883 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / Why we need it:
This finally fixes a bug we introduced in #3764 where a GameServer blocks its state at Starting until the PodIP is populated - which slowed down scaling and a bunch of other things for something that not everyone needed.
This is no longer the case -- PodIP will be populated on the GameServer as it becomes populated on the Pod and is no longer blocking.
** If you are used to the original behaviour, make sure to factor this
into your existing architecture when upgrading.**
Which issue(s) this PR fixes:
Closes #3960
Special notes for your reviewer:
Details: